🟡 Magic Number

💡 The scheduled run time (23:00) is hardcoded as a magic number. Consider extracting it to a named constant or configuration for better clarity and maintainability:

private const int ScheduledHour = 23;
private static readonly TimeOnly RunningTime = new(ScheduledHour, 0, 0);

🟡 Redundant DateTime.Now Calls

💡 DateTime.Now is called twice within the same loop iteration. While the time difference is negligible here, it's cleaner and more consistent to capture it once and reuse:

DateTime now = DateTime.Now;
TimeOnly currentTime = TimeOnly.FromDateTime(now);
DateOnly today = DateOnly.FromDateTime(now);

🟠 Blocking Sleep on Main Thread

💡 Thread.Sleep(10000) blocks the current thread and prevents clean application shutdown. Consider using await Task.Delay(10000) and making Main async:

public static async Task Main(string[] args)
{
    // ...
    await Task.Delay(10000);
}

This also improves responsiveness and enables graceful cancellation with CancellationToken.

🟠 No Graceful Shutdown Handling

💡 The application runs an infinite while(true) loop with no means to exit cleanly. Consider adding a CancellationToken or handling Console.CancelKeyPress to allow a graceful stop when the user presses Ctrl+C:

CancellationTokenSource cts = new();
Console.CancelKeyPress += (_, e) => { e.Cancel = true; cts.Cancel(); };
// Use cts.Token in your loop and Task.Delay

🟡 Redundant Constructor Logic

💡 WinnerScore and LoserScore are computed from other properties passed to the constructor. They could be refactored as computed (expression-bodied) properties, eliminating the need to store them and simplifying the constructor:

public int WinnerScore => Team1Score > Team2Score ? Team1Score : Team2Score;
public int LoserScore => Team1Score < Team2Score ? Team1Score : Team2Score;

This removes the ternary logic and Winner/Loser string comparisons from the constructor.

🟡 Synchronous Web Scraping

💡 HtmlWeb.Load() performs synchronous I/O, blocking the thread. Consider using the async overload await web.LoadAsync(...) for better resource utilization, and make Scan() an async method.

🟠 Tight Coupling via Static Call

💡 Email.Send(gameList) is called directly as a static method, creating tight coupling between BasketballScanner and Email. Consider making these instance methods and using dependency injection or passing an abstraction (e.g., IEmailService) to improve testability and flexibility.

🟢 Null Checks on HTML Nodes

🟢 Input Validation with TryParse

🟢 Secure Credential Handling